Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stats): incorrect last point of previous batch step (force update) #958

Merged
merged 10 commits into from
Jul 1, 2024

Conversation

bragov4ik
Copy link
Contributor

@bragov4ik bragov4ik commented Jun 28, 2024

  • fix(stats): Fixed last point of previous batch step being retrieved incorrectly when forcing reupdate of an existing data. Also added regression on this bug to prevent it in the future.
  • fix(stats): In the meantime fixed a small overlapping between batch steps (1 ns due to using RangeInclusive): end of batch step range is now not included (Range instead of RangeInclusive). Relevant code is changed accordingly.

@bragov4ik bragov4ik self-assigned this Jun 28, 2024
@bragov4ik bragov4ik linked an issue Jul 1, 2024 that may be closed by this pull request
@bragov4ik bragov4ik force-pushed the bragov4ik/fix-charts-cumulative branch 2 times, most recently from f8eba71 to 5d0263d Compare July 1, 2024 09:17
@bragov4ik bragov4ik merged commit f4623a6 into main Jul 1, 2024
3 checks passed
@bragov4ik bragov4ik deleted the bragov4ik/fix-charts-cumulative branch July 1, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stats: incorrect data in cumulative charts
2 participants