Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STATS] Update stats architecture #891

Merged
merged 137 commits into from
Jun 26, 2024
Merged

[STATS] Update stats architecture #891

merged 137 commits into from
Jun 26, 2024

Conversation

bragov4ik
Copy link
Contributor

@bragov4ik bragov4ik commented May 24, 2024

Main goal: allow more complex relations between charts

Main changes overview:

  • flexible framework for data retrieval, processing, and storage
  • flexible data dependencies with synchronized and efficient updates
  • config reorganization and changes (see migration in config files folder for more)

Tech debt mitigated:

  • order parameter in config changed to list; overrideable with env
  • compilation without test-utils fix (tests can be run w/o the feature)
  • remove duplication of configs (in runtime)
  • deprecate toml config
  • more accurate metrics collection (exclude mutex waiting)
  • fix fill logic when to in request is None
  • update some dependencies versions

Collateral changes:

  • querying get_chart_data (now get_line_chart_data) without fill_missing_dates now returns data only within range according to missing date policy (for FillPrevious the first data point is moved from outside the range, if needed) (previously it could add a point before the range)

@bragov4ik bragov4ik marked this pull request as draft May 24, 2024 12:06
@bragov4ik bragov4ik force-pushed the bragov4ik/chart-resolutions branch from 50f3c0f to 60f49f6 Compare June 6, 2024 13:45
@bragov4ik bragov4ik force-pushed the bragov4ik/chart-resolutions branch from 06eb9b4 to 806146d Compare June 24, 2024 10:53
@bragov4ik bragov4ik requested a review from sevenzing June 24, 2024 14:07
Copy link
Contributor

@sevenzing sevenzing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets update README.md: ENVs and Config section

@bragov4ik bragov4ik merged commit f8e81fc into main Jun 26, 2024
4 of 5 checks passed
@bragov4ik bragov4ik deleted the bragov4ik/chart-resolutions branch July 3, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants