-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STATS] Update stats architecture #891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bragov4ik
force-pushed
the
bragov4ik/chart-resolutions
branch
from
June 6, 2024 13:45
50f3c0f
to
60f49f6
Compare
sevenzing
reviewed
Jun 24, 2024
sevenzing
reviewed
Jun 24, 2024
sevenzing
reviewed
Jun 24, 2024
bragov4ik
force-pushed
the
bragov4ik/chart-resolutions
branch
from
June 24, 2024 10:53
06eb9b4
to
806146d
Compare
sevenzing
reviewed
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets update README.md: ENVs and Config section
logs + comments + formatting + naming
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal: allow more complex relations between charts
Main changes overview:
migration
in config files folder for more)Tech debt mitigated:
order
parameter in config changed to list; overrideable with envCollateral changes:
get_line_chart_data
) withoutfill_missing_dates
now returns data only within range according to missing date policy (for FillPrevious the first data point is moved from outside the range, if needed) (previously it could add a point before the range)