Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bens image name the same as release tag #1140

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

alik-agaev
Copy link
Contributor

No description provided.

@rimrakhimov
Copy link
Member

rimrakhimov commented Dec 11, 2024

I suggest to rename blockscout-ens directory to be bens instead of passing docker-context-path and dockerfile-path explicitly. In my opinion, this kind of flexibility is unnecessary as almost all services except blockscout-ens and multichain-search follow the same structure with service names being the same as directories.

multichain-search is deprecated overall, so renaming blockscout-ens to bens will result in all services being the same

@rimrakhimov rimrakhimov self-requested a review December 11, 2024 14:06
@sevenzing
Copy link
Contributor

will rename blockscout-ens in next pr, for now merge it

@sevenzing sevenzing merged commit 35a6209 into main Dec 25, 2024
5 checks passed
@sevenzing sevenzing deleted the fix-bens-release branch December 25, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants