Merge pull request #521 from blockchain/remove-survey

Remove survey link from wallet home
blockchain · Jul 26, 2016 · 85e5b80 · 85e5b80
2 parents 519a085 + 9246f30
commit 85e5b80
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 13 deletions.
diff --git a/app/templates/did-you-know.jade b/app/templates/did-you-know.jade
@@ -1,6 +1,6 @@
 .dyk
   .flex-between.flex-center.mbl
-    h5.mvn.type-h5.em-400(translate="CONTRIBUTE")
+    h5.mvn.type-h5.em-400(translate="DYK")
     .hashtag.em-400.em-alt.flex-center(ng-class="dyk.type.toLowerCase()") 
       | {{ dyk.type | translate }}
   .widget

diff --git a/assets/js/directives/did-you-know.directive.js b/assets/js/directives/did-you-know.directive.js
@@ -15,6 +15,6 @@ function didYouKnow (DidYouKnow) {
   return directive;
 
   function link (scope, elem, attrs) {
-    scope.dyk = DidYouKnow.getSurvey();
+    scope.dyk = DidYouKnow.getRandom();
   }
 }
diff --git a/assets/js/services/didYouKnow.service.js b/assets/js/services/didYouKnow.service.js
@@ -33,22 +33,24 @@ function DidYouKnow () {
       type: 'EDUCATIONAL',
       text: 'DYK_BTC_VALUE',
       icon: 'ti-stats-up'
-    }, {
-      id: 5,
-      title: 'SEND_FEEDBACK',
-      type: 'SURVEY',
-      text: 'DYK_FEEDBACK_VALUE',
-      icon: 'ti-announcement',
-      linkText: 'SHARE_FEEDBACK',
-      external: true,
-      state: 'https://blockchain.co1.qualtrics.com/SE/?SID=SV_0PMH4ruxU5krOmh'
     }
   ];
 
+  const survey = {
+    id: 5,
+    title: 'SEND_FEEDBACK',
+    type: 'SURVEY',
+    text: 'DYK_FEEDBACK_VALUE',
+    icon: 'ti-announcement',
+    linkText: 'SHARE_FEEDBACK',
+    external: true,
+    state: 'https://blockchain.co1.qualtrics.com/SE/?SID=SV_0PMH4ruxU5krOmh'
+  };
+
   const service = {
     getAll: () => dyks, // Only used for tests
     getRandom: () => dyks[getRandInRange(0, dyks.length - 1)],
-    getSurvey: () => dyks[4]
+    getSurvey: () => survey
   };
   return service;
 }
diff --git a/tests/directives/did-you-know.coffee b/tests/directives/did-you-know.coffee
@@ -55,7 +55,7 @@ describe "Did You Know directive", ->
       #   linkText: 'SECURITY',
       #   state: 'wallet.common.settings.security'
       # }
-      spyOn(DidYouKnow, "getSurvey").and.returnValue {
+      spyOn(DidYouKnow, "getRandom").and.returnValue {
         id: 5,
         title: 'SEND_FEEDBACK',
         type: 'SURVEY',