Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a redact agent #571

Open
wants to merge 1 commit into
base: v1.0
Choose a base branch
from
Open

feat: Add a redact agent #571

wants to merge 1 commit into from

Conversation

baxen
Copy link
Collaborator

@baxen baxen commented Jan 10, 2025

This is not a full summarization, but instead slows down how quickly tokens accumulate by redacting recurring resources. We need to test this, it does mean the model cannot see all the changes that happened. However those should be redundant with other tool uses

This is not a full summarization, but instead slows down how quickly
tokens accumulate by redacting recurring instances. We need to test
this, it does mean the model cannot see all the changes that happened.
However those should be redundant with other tool uses
Copy link

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

// Map to track the last occurrence of each resource URI
let mut uri_last_index: HashMap<String, usize> = HashMap::new();

// First pass: find all resource URIs and their last occurrence
Copy link
Collaborator

@salman1993 salman1993 Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: i think we can do this in one pass by iterating in reverse order

@michaelneale
Copy link
Collaborator

nice - wasn't familiar with this use of "redact" as a term, but could be good. I read correctly this means that the redaction shows earlier in the prompt (minor downside being cache loss?).

it does mean the model cannot see all the changes that happened

I wonder if longer term this doesn't matter too much, at least for code/text changes where with some future system it could use git staging/working commits and then ask it to look back in diff form?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants