fix: template directories must be ignored by Go #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`|` is not supported in filenames retrieved by the Go toolchain, as Windows doesn't allow it in filenames. As we're zipping these files, this isn't a concern for us, but it's still prevented by Go. To work around this we create a dummy `go.mod` file which Go interprets as a separate module and thus ignores. Fixes #991
alecthomas
requested review from
dhanji,
wesbillman and
worstell
as code owners
|
How did you figure this out?!? 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
|is not supported in filenames retrieved by the Go toolchain, as Windows doesn't allow it in filenames. As we're zipping these files, this isn't a concern for us, but it's still prevented by Go. To work around this we create a dummygo.modfile which Go interprets as a separate module and thus ignores.Ask me how I figured this out?
Fixes #991