feat: generate kotlin external modules from FTL tooling #988
Conversation
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
worstell
force-pushed
the
worstell/20240223-generate-kotlin-external-modules-in-ftl
branch
3 times, most recently
from
e8d0020 to
06dedc8
Compare
| }, scaffolder.Functions(funcs)) | ||
| } | ||
|
|
||
| var scaffoldFuncs = scaffolder.FuncMap{ |
There was a problem hiding this comment.
These functions are already defined in a couple of places. Let's factor them into a single location and include them by default in internal.ScaffoldZip.
There was a problem hiding this comment.
scaffolder.Functions() is cumulative, so the bespoke functions can still be added in each individual location.
| val parameterizedDataRef: ParamTestData<T>, | ||
| val withAlias: String, | ||
| val unit: Unit, | ||
| ) |
| {{- if $imports}} | ||
| {{range $import := $imports}} | ||
| import {{$import}} | ||
| {{- end}}{{end}} |
There was a problem hiding this comment.
This is quite difficult to read. Let's introduce some whitespace here between the different semantic sections. The intent of using {{- and - }}, is to allow the template to have meaningful whitespace while still generating clean output.
There was a problem hiding this comment.
updated! hopefully clearer chunks now
| .removeSuffix("*/") | ||
| .lines() | ||
| .map { it.trim().removePrefix("*").trim() } | ||
| .filter { it.isNotEmpty() } |
There was a problem hiding this comment.
I don't think we want to remove empty lines in the comments do we?
There was a problem hiding this comment.
ah the thinking here was to filter out the lines that become empty after removing the javadoc start/end markers /** and */- but good point, we don't want to lose intentional line spacing. I've updated to only filter out the lines that contain start/end markers with nothing else
worstell
force-pushed
the
worstell/20240223-generate-kotlin-external-modules-in-ftl
branch
from
8cfe6b8 to
c575fab
Compare
worstell
force-pushed
the
worstell/20240223-generate-kotlin-external-modules-in-ftl
branch
from
c7501aa to
b8280e0
Compare
worstell
deleted the
worstell/20240223-generate-kotlin-external-modules-in-ftl
branch
fixes #970
This implementation diverges from the kotlin-runtime module generator logic in that it omits
IngressHttporJsonannotations in external modules. I don't think we need those for the generated external modules.Will follow with a change to remove the module generator entirely and stop releasing its JAR.