Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure ftl serve --background waits for controller to start #977

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

wesbillman
Copy link
Collaborator

@wesbillman wesbillman commented Feb 23, 2024

Example:

ftl serve --background && ftl status
info: FTL running in background with pid: 26990

error: Unary RPC failed: unavailable: dial tcp [::1]:8892: connect: connection refused: /xyz.block.ftl.v1.ControllerService/Status
{
  "controllers": [
    {
      "key": "C01HQBDJSK0C249VV2QBN3B856J",
      "endpoint": "http://localhost:8892"
    }
  ],
  "runners": [
...

We'll probably want a way in the future to not print the error in the status request, but it shouldn't stop the Integration/CI flow from working here.

@wesbillman wesbillman force-pushed the make-ftl-serve-wait-for-controller branch from 60ffd65 to 559ad47 Compare February 23, 2024 16:46
@wesbillman wesbillman merged commit 72ff1fd into main Feb 23, 2024
11 checks passed
@wesbillman wesbillman deleted the make-ftl-serve-wait-for-controller branch February 23, 2024 16:52
@wesbillman
Copy link
Collaborator Author

Fixes #962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant