feat: switch alias to json
#943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
requested review from
alecthomas,
dhanji and
worstell
as code owners
wesbillman
commented
Feb 15, 2024
backend/schema/field.go
Outdated
| Comments []string `parser:"@Comment*" protobuf:"3"` | ||
| Name string `parser:"@Ident" protobuf:"2"` | ||
| Type Type `parser:"@@" protobuf:"4"` | ||
| HTTPAlias string `parser:"('alias' 'http' @Ident)?" protobuf:"5"` |
There was a problem hiding this comment.
Just want to check that we're ok with this new HTTPAlias name.
There was a problem hiding this comment.
Also, @alecthomas does this parser change look correct to you? I sort of just guessed 😬
worstell
approved these changes
Feb 15, 2024
alecthomas
approved these changes
Feb 15, 2024
| @@ -12,11 +12,11 @@ func TestTransformFromAliasedFields(t *testing.T) { | |||
| schemaText := ` | |||
| module test { | |||
| data Inner { | |||
| waz String alias foo | |||
| waz String alias http foo | |||
There was a problem hiding this comment.
I'm wondering if we should call the aliasing json? It is currently specific to the http ingress, but it is also only to do with JSON fields, not HTTP in general. I've gone back and forth on it, WDYT @wesbillman @worstell ?
Just thinking about it again - it's called "JSON" in each language. Let's call it that here too.
There was a problem hiding this comment.
yeah I like that too!
wesbillman
force-pushed
the
switch-alias-to-json
branch
from
fe59473 to
d570dce
Compare
wesbillman
force-pushed
the
switch-alias-to-json
branch
from
c0d12ac to
f7ea4f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #908