feat: add array support to http ingress #915
Conversation
go-runtime/server/server.go
Outdated
| fmt.Printf("resp: %v\n", resp) | ||
|
|
||
| respdata, err := encoding.Marshal(resp) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| fmt.Printf("respdata: %v\n", string(respdata)) |
There was a problem hiding this comment.
@alecthomas I might need to pick your brain on this one. It seems like when we encode arrays of strings, they are getting double quoted here. Not sure if that's what we want, or if I need to make a change to the encoder. It also causes code after this to fail since it can't probably json encode the response for recordCall in observability.
This is what is printed out when I run the integration tests for HTTP Ingress.
resp: {0 map[] ["hello" "world"] None}
respdata: {"status":0,"headers":{},"body":[""hello"",""world""],"error":null}
There was a problem hiding this comment.
Use repr.Println() as it will tell you what the values actually are. %v is useless.
There was a problem hiding this comment.
ah yeah!
resp:
builtin.HttpRequest[[]string]{
Method: "GET",
Path: "/array/string",
PathParameters: map[string]string{ },
Query: map[string][]string{ },
Headers: map[string][]string{
"Accept-Encoding": []string{
"gzip",
},
"Content-Length": []string{
"17",
},
"Content-Type": []string{
"application/json",
},
"User-Agent": []string{
"Go-http-client/1.1",
},
},
Body: []string{
"\"hello\"",
"\"world\"",
},
}
respdata:
[]byte("{\"status\":0,\"headers\":{},\"body\":[\"\"hello\"\",\"\"world\"\"],\"error\":null}")
There was a problem hiding this comment.
Is that before or after? Whatever it is, it should tell you that either the strings are coming in already with extra quotes, or they're getting added by encode. That should point you closer to where the problem lies.
There was a problem hiding this comment.
Thanks for the heads up on this one! The issue was that the data in the req was already encoded incorrectly and since it's just returned in the Body: req.Body the response was also encoded incorrectly. Garbage in, garbage out. 🤦
wesbillman
force-pushed
the
http-ingress-array-support
branch
4 times, most recently
from
551e814 to
9a4d3e0
Compare
integration/integration_test.go
Outdated
| // httpCall(rd, http.MethodPost, "/array/data", jsonData(t, []obj{{"item": "a"}, {"item": "b"}}), func(t testing.TB, resp *httpResponse) { | ||
| // assert.Equal(t, 200, resp.status) | ||
| // assert.Equal(t, []string{"application/json; charset=utf-8"}, resp.headers["Content-Type"]) | ||
| // assert.Equal(t, jsonData(t, []obj{{"item": "a"}, {"item": "b"}}), resp.bodyBytes) | ||
| // }), |
There was a problem hiding this comment.
@alecthomas I have this one commented out because it seems like Arrays of DataRefs fail to monomorphize correctly. I took a stab at fixing it in data.go, but I think I was causing more harm than good 😂
Maybe we can take a peek together on this one.
It seems to happen when monomorphising to get the body of the request object.
func getBodyField(dataRef *schema.DataRef, sch *schema.Schema) (*schema.Field, error) {
data, err := sch.ResolveDataRefMonomorphised(dataRef)
if err != nil {
return nil, err
}
wesbillman
force-pushed
the
http-ingress-array-support
branch
from
9a4d3e0 to
c2cfcec
Compare
| } | ||
|
|
||
| // Transform the array element to its aliased form. | ||
| if dataRef, ok := t.Element.(*schema.DataRef); ok { |
There was a problem hiding this comment.
Could this not call bodyForType recursively? What if you have an array of strings? Or an array of arrays?
wesbillman
force-pushed
the
http-ingress-array-support
branch
from
fcd04dc to
54c2a4c
Compare
wesbillman
force-pushed
the
http-ingress-array-support
branch
from
54c2a4c to
321d49c
Compare
wesbillman
force-pushed
the
http-ingress-array-support
branch
from
321d49c to
6a2ec0c
Compare
| // Since the query and header parameters are a `map[string][]string` | ||
| // we need to convert them before they go through the `transformFromAliasedFields` call | ||
| // otherwise they will fail the type check. | ||
| queryMap := make(map[string]any) | ||
| for key, values := range r.URL.Query() { | ||
| valuesAny := make([]any, len(values)) | ||
| for i, v := range values { | ||
| valuesAny[i] = v | ||
| } | ||
| queryMap[key] = valuesAny | ||
| } | ||
|
|
||
| headerMap := make(map[string]any) | ||
| for key, values := range r.Header { | ||
| valuesAny := make([]any, len(values)) | ||
| for i, v := range values { | ||
| valuesAny[i] = v | ||
| } | ||
| headerMap[key] = valuesAny | ||
| } |
There was a problem hiding this comment.
Not sure if there's a better way to handle this that will keep the type checker happy. But since they query and headers types don't match map[string]any and their values don't pass []any the transformFromAliasedFields will fail.
There was a problem hiding this comment.
I think that's about all you can do here yeah.
No description provided.