feat: change HttpResponse<R> to HttpResponse<R, E> #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
requested review from
dhanji,
wesbillman and
worstell
as code owners
alecthomas
force-pushed
the
aat/http-response-error
branch
from
5e27314 to
d619b4a
Compare
This allows for seperate HTTP response structures for valid responses and errors, codifying the best practice of having a distinct error response structure. Fixed a bug where sdk.Option was not using encoding.Marshal(). Refactored ingress response construction such that headers and payload are entirely handled by a single function, ResponseForVerb.
alecthomas
force-pushed
the
aat/http-response-error
branch
from
fcf8ff7 to
54a017c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for seperate HTTP response structures for valid responses and errors, codifying the best practice of having a distinct error response structure.
Fixed a bug where sdk.Option was not using encoding.Marshal().
Refactored ingress response construction such that headers and payload are entirely handled by a single function, ResponseForVerb.