fix: databasetesting.CreateForDevel() now tries to connect for 10s #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to be a race between when the Docker PG healthcheck passes,
and when the Docker port becomes available:
trace: exec: cd . && docker inspect --format \{\{.State.Health.Status}} ftl-db-1
debug: Postgres DSN: ***localhost:54320/ftl?sslmode=disable
ftl: error: failed to connect to `host=localhost user=postgres database=`: failed to receive message (unexpected EOF)
It's not clear if that's a deficiency in Docker, or perhaps pg_isready
is only checking the Unix socket and not the TCP port, and there's some
delay between the two becoming available. Either way, this should solve
it.
alecthomas
requested review from
dhanji,
wesbillman and
worstell
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a race between when the Docker PG healthcheck passes, and when the Docker port becomes available:
It's not clear if that's a deficiency in Docker, or perhaps pg_isready is only checking the Unix socket and not the TCP port, and there's some delay between the two becoming available. Either way, this should solve it.