fix: monomorphising would fail under some circumstances #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I originally intended to replace `DataRef` references to type parameters, with concrete `TypeParameter` instances, but this ended up conflating the parameter declaration and the reference. Instead, it's now left as a `DataRef`, and I've made `TypeParameter` no longer implement `Type`. Note that it being a `DataRef` doesn't make much sense either, because it's not a data structure, but that's part of a large issue where data references can also refer to verbs within the schema parsing. The correct solution here is to use an untyped `Ref` everwhere and resolve these to the correct reference types when validating.
alecthomas
requested review from
dhanji,
wesbillman and
worstell
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I originally intended to replace
DataRefreferences to type parameters, with concreteTypeParameterinstances, but this ended up conflating the parameter declaration and the reference. Instead, it's now left as aDataRef, and I've madeTypeParameterno longer implementType.Note that it being a
DataRefdoesn't make much sense either, because it's not a data structure, but that's part of a large issue where data references can also refer to verbs within the schema parsing. The correct solution here is to use an untypedRefeverwhere and resolve these to the correct reference types when validating.