fix: fix broken FTL examples #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
force-pushed
the
fix-examples
branch
from
fc63fb8 to
1987720
Compare
alecthomas
approved these changes
Feb 2, 2024
examples/go/echo/echo.go
Outdated
| func Echo(ctx context.Context, req EchoRequest) (EchoResponse, error) { | ||
| fmt.Println("Echo received a request!") | ||
| tresp, err := sdk.Call(ctx, time.Time, time.TimeRequest{}) | ||
| if err != nil { | ||
| return EchoResponse{}, err | ||
| } | ||
| return EchoResponse{Message: fmt.Sprintf("Hello, %s!!! It is %s!", req.Name.Default("anonymous"), tresp.Time)}, nil | ||
| return EchoResponse{Message: fmt.Sprintf("Hello, %s!!! It is %s!", req.Name.Default("anonymous"), tresp)}, nil |
| return when { | ||
| req.contextKeys != null -> AdResponse(ads = contextualAds(req.contextKeys)) | ||
| else -> AdResponse(ads = randomAds()) | ||
| @Ingress(Method.GET, "/get", HTTP) |
There was a problem hiding this comment.
Weird, we should get rid of HTTP and call this @HttpIngress. It's not going to be usable for any other type such as gRPC anyway.
There was a problem hiding this comment.
Yeah good call. I'll make a ticket to clean this up.
#874
wesbillman
force-pushed
the
fix-examples
branch
from
1987720 to
60f5e57
Compare
wesbillman
commented
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.