chore: add more httpingress integration tests #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
requested review from
alecthomas,
dhanji and
worstell
as code owners
wesbillman
commented
Feb 1, 2024
integration/integration_test.go
Outdated
Comment on lines
116
to
120
| respBodyStr := strings.Trim(string(resp.bodyBytes), "\"") | ||
| decodedBody, err := base64.StdEncoding.DecodeString(respBodyStr) | ||
| if err != nil { | ||
| t.Fatalf("Failed to decode base64: %v", err) | ||
| } |
There was a problem hiding this comment.
@alecthomas maybe I should change the behavior of the []byte response to already be decoded? So that if we send bytes to an ingress and return them, they should match? Whatcha think?
wesbillman
force-pushed
the
add-more-http-ingress-testing
branch
from
2534d4d to
73d4675
Compare
wesbillman
force-pushed
the
add-more-http-ingress-testing
branch
from
73d4675 to
1925465
Compare
alecthomas
reviewed
Feb 1, 2024
|
|
||
| return body, nil | ||
| case *schema.Bytes: | ||
| var base64String string |
There was a problem hiding this comment.
I think if you make this a []byte then json.Unmarshal will Just Work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.