feat: escape html to prevent XSS #852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
requested review from
alecthomas,
dhanji and
worstell
as code owners
alecthomas
reviewed
Jan 31, 2024
There was a problem hiding this comment.
I don't think this is correct is it? Did you test it? It looks like this will escape the entire response. I think XSS is more about when fragments from other sources are injected into existing HTML without them being escaped.
I don't think FTL can do anything about XSS at the transport layer. If we wanted to do something, we'd need to provide our own HTML templating which prevented XSS.
|
Ah gotcha. Makes sense. I'll close this for now as it definitely doesn't solve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #838