chore: parameterize integration tests #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
alecthomas
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
This is awesome Lizzy, thanks so much for doing this!
Now that you've separated the tests, we should run every integration test as parallel jobs in CI. We'll need a way to list the tests. What I have done in the past is to just grep out the test functions like grep '^func Test' | awk '{print $2}' | cut -d'(' -f1. I think you'll need to push this into a GHA variable, and reference it in a matrix of (language, test), if that's possible.
| t.moduleRoot = filepath.Join(modulesDir, t.moduleName) | ||
| t.modulePath = t.moduleRoot | ||
| case "kotlin": | ||
| t.moduleRoot = filepath.Join(modulesDir, fmt.Sprintf("ftl-module-%s", t.moduleName)) |
There was a problem hiding this comment.
Unrelated but I think we should get rid of ftl-module-<name> and just have <name>.
| import ( | ||
| "context" | ||
|
|
||
| ftl "github.com/TBD54566975/ftl/go-runtime/sdk" // Import the FTL SDK. |
There was a problem hiding this comment.
Also unrelated but I think we should change this package from sdk to ftl
worstell
force-pushed
the
worstell/20240126-refactor-integration-tests
branch
19 times, most recently
from
9217ae1 to
a34169c
Compare
refactors integration tests to execute identically across runtimes with this change, we can also specify tests to run with the integration-test script (e.g. `integration-tests TestLifecycle` — all tests are fully encapsulated and can execute alone). providing no option will run all tests. tests have been split into the following: - TestLifecycle (init, deploy, call) - TestHttpIngress (tests all http methods and tests aliased fields) - TestDatabase - TestExternalCalls (kotlin -> go call, kotlin -> kotlin call, etc. for all runtime permutations) a couple small changes captured by the integration tests are also included in this PR: - Database.kt converts module name and DB name to uppercase to align with the Go DB SDK - Kotlin schema extractor includes module names for all DataRef schema objects, even those declared in the referencing module (this fixes builtin.HttpRequest/Response types for HTTP ingress in Kotlin)
worstell
force-pushed
the
worstell/20240126-refactor-integration-tests
branch
from
a34169c to
4824784
Compare
|
Huge, Lizzy, nice work and thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactors integration tests to execute identically across runtimes
with this change, we can also specify tests to run with the integration-test script (e.g.
integration-tests TestLifecycle— all tests are fully encapsulated and can execute alone). providing no option will run all tests.tests have been split into the following:
a couple small changes captured by the integration tests are also included in this PR: