feat: support http-valid characters in ingress paths #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
github-actions
bot
changed the title
worstell
force-pushed
the
worstell/20240119-http-parsing
branch
from
05c0a00 to
2c54469
Compare
alecthomas
approved these changes
Jan 19, 2024
backend/schema/metadataingress.go
Outdated
| @@ -79,7 +79,7 @@ type IngressPathComponent interface { | |||
| type IngressPathLiteral struct { | |||
| Pos Position `parser:"" protobuf:"1,optional"` | |||
|
|
|||
| Text string `parser:"@Ident" protobuf:"2"` | |||
| Text string `parser:"@~Whitespace+" protobuf:"2"` | |||
There was a problem hiding this comment.
I think this will need to be something like @~(Whitespace | '/' | '{' | '}')+, otherwise it will just keep consuming, including path parameters?
There was a problem hiding this comment.
ah mixed up literal and the path parameter matchers. updated to @~(Whitespace | '/' | '{' | '}')+ for literal and leaving as '{' @Ident '}' for the path param - does that sound right?
worstell
force-pushed
the
worstell/20240119-http-parsing
branch
from
7f35bd6 to
8c7879a
Compare
worstell
force-pushed
the
worstell/20240119-http-parsing
branch
from
96bc754 to
0a569d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #811