feat: update .gitignore with _ftl during Go init #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
worstell
force-pushed
the
worstell/20240116-update-gitignore-during-init
branch
from
8412dbf to
2a1f339
Compare
alecthomas
approved these changes
Jan 16, 2024
| examples/**/go.work | ||
| examples/**/go.work.sum | ||
| **/_ftl |
There was a problem hiding this comment.
The examples/ are here in this repo, because we have scaffolding called the same _ftl
Actually let's keep this, and rename the folders in the template directories to _ftl.tmpl - the scaffolder should rename that correctly, but maybe just verify ftl build still works on a Go module.
There was a problem hiding this comment.
ah nice! updated and validated the build
| @@ -143,3 +148,27 @@ var scaffoldFuncs = template.FuncMap{ | |||
| return reflect.Indirect(reflect.ValueOf(v)).Type().Name() | |||
| }, | |||
| } | |||
|
|
|||
| func updateGitIgnore(ctx context.Context, dir string) error { | |||
There was a problem hiding this comment.
That's a nice clean function Lizzy, nice!
worstell
force-pushed
the
worstell/20240116-update-gitignore-during-init
branch
from
09dad6b to
af0cbd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #776