fix: redeploy all modules on schema changes #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
approved these changes
Jan 16, 2024
cmd/ftl/cmd_dev.go
Outdated
| @@ -38,6 +41,24 @@ func (d *devCmd) Run(ctx context.Context, client ftlv1connect.ControllerServiceC | |||
| d.modules = make(map[string]moduleFolderInfo) | |||
| d.client = client | |||
|
|
|||
| stream, err := client.PullSchema(ctx, connect.NewRequest(&ftlv1.PullSchemaRequest{})) | |||
There was a problem hiding this comment.
This should be in the goroutine itself, and should handle disconnects of the stream. ie. there should be two loops, an outer one initiating the stream and an inner one pulling from the stream. Don't forget to close the stream if it errors.
|
Rebuilds are fast with Go, but not so much with Kotlin, so we should be smarter about this in future. Can you create a ticket to remind us to fix this? |
|
wesbillman
force-pushed
the
786-ftl-dev-should-watch-the-cluster-for-schema-changes-and-rebuild-on-change
branch
2 times, most recently
from
ae03344 to
a541198
Compare
alecthomas
approved these changes
Jan 17, 2024
cmd/ftl/cmd_dev.go
Outdated
| continue | ||
| } | ||
|
|
||
| for { |
There was a problem hiding this comment.
A better pattern is:
for stream.Receive() {
msg := stream.Msg()
// ..
}
stream.Close()
// ...
wesbillman
force-pushed
the
786-ftl-dev-should-watch-the-cluster-for-schema-changes-and-rebuild-on-change
branch
from
a541198 to
003faf3
Compare
wesbillman
deleted the
786-ftl-dev-should-watch-the-cluster-for-schema-changes-and-rebuild-on-change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
ftl devcommand detects a schema change in any module, it will trigger a rebuild of all modules, including the one that caused the schema change.This isn't ideal because we might end up rebuilding a single module twice (if it caused a schema change), but the logic is simple and rebuilds are fast.