Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(generator): only release generator executable; resolve child POMs #607

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix(generator): only release generator executable; resolve child POMs #607

merged 1 commit into from
Nov 27, 2023

Conversation

worstell
Copy link
Contributor

No description provided.

@github-actions github-actions bot changed the title fix: only release generator executable; resolve child POMs fix(generator): only release generator executable; resolve child POMs Nov 16, 2023
@worstell worstell force-pushed the worstell/20231116-include-only-jar-with-dependencies-ftl-generator branch 2 times, most recently from 1eb70a1 to 99265ec Compare November 17, 2023 17:47
@worstell worstell changed the title fix(generator): only release generator executable; resolve child POMs [WIP] fix(generator): only release generator executable; resolve child POMs Nov 17, 2023
@worstell worstell marked this pull request as draft November 17, 2023 19:42
@worstell worstell force-pushed the worstell/20231116-include-only-jar-with-dependencies-ftl-generator branch 2 times, most recently from e50fcc7 to 1301f65 Compare November 20, 2023 17:06
@github-actions github-actions bot changed the title [WIP] fix(generator): only release generator executable; resolve child POMs fix(generator): [WIP] only release generator executable; resolve child POMs Nov 20, 2023
@worstell worstell force-pushed the worstell/20231116-include-only-jar-with-dependencies-ftl-generator branch 6 times, most recently from ffc2f28 to ac0abde Compare November 20, 2023 17:49
@worstell worstell changed the title fix(generator): [WIP] only release generator executable; resolve child POMs fix: only release generator executable; resolve child POMs Nov 20, 2023
@worstell worstell marked this pull request as ready for review November 20, 2023 18:09
@worstell worstell requested a review from alecthomas November 20, 2023 18:09
@worstell worstell force-pushed the worstell/20231116-include-only-jar-with-dependencies-ftl-generator branch from 9490158 to 522b68e Compare November 20, 2023 19:32
@github-actions github-actions bot changed the title fix: only release generator executable; resolve child POMs "fix: only release generator executable; resolve child POMs" already follows the Conventional Commits guidelines, so no change is necessary. The commit message can stay as it is. Nov 20, 2023
@github-actions github-actions bot changed the title "fix: only release generator executable; resolve child POMs" already follows the Conventional Commits guidelines, so no change is necessary. The commit message can stay as it is. fix: only release generator executable; resolve child POMs Nov 20, 2023
@worstell worstell force-pushed the worstell/20231116-include-only-jar-with-dependencies-ftl-generator branch from fb076af to a275834 Compare November 20, 2023 19:35
@worstell worstell marked this pull request as draft November 20, 2023 20:15
@github-actions github-actions bot changed the title fix: only release generator executable; resolve child POMs The commit message is already in Conventional Commits (CC) format. Therefore, it doesn't need any modification. The output is: "fix: only release generator executable; resolve child POMs" Nov 20, 2023
@worstell worstell force-pushed the worstell/20231116-include-only-jar-with-dependencies-ftl-generator branch from 645a68a to 4f983d0 Compare November 20, 2023 21:48
@github-actions github-actions bot changed the title The commit message is already in Conventional Commits (CC) format. Therefore, it doesn't need any modification. The output is: "fix: only release generator executable; resolve child POMs" fix: only release generator executable; resolve child POMs Nov 20, 2023
@github-actions github-actions bot changed the title fix: only release generator executable; resolve child POMs The commit message already has a Conventional Commits (CC) prefix. Nov 20, 2023
alecthomas added a commit that referenced this pull request Nov 20, 2023
@alecthomas
fix: early-exit gptcc because it's a bit too enthusiastic
889fca6 
See #607 for an example :\
alecthomas added a commit that referenced this pull request Nov 20, 2023
@alecthomas
fix: early-exit gptcc because it's a bit too enthusiastic
df57cfd 
See #607 for an example :\
@alecthomas alecthomas mentioned this pull request Nov 20, 2023
Merged
alecthomas added a commit that referenced this pull request Nov 20, 2023
@alecthomas
fix: early-exit gptcc because it's a bit too enthusiastic
5533bbe 
See #607 for an example :\
alecthomas added a commit that referenced this pull request Nov 20, 2023
@alecthomas @github-actions
fix: early-exit gptcc because it's a bit too enthusiastic (#621)
99ed211 
See #607 for an example :\

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@worstell worstell force-pushed the worstell/20231116-include-only-jar-with-dependencies-ftl-generator branch 7 times, most recently from f68b54f to 328fe18 Compare November 25, 2023 01:51
@worstell worstell marked this pull request as ready for review November 25, 2023 01:51
@worstell worstell force-pushed the worstell/20231116-include-only-jar-with-dependencies-ftl-generator branch 13 times, most recently from dcf72b9 to 95038c8 Compare November 27, 2023 18:26
@worstell worstell force-pushed the worstell/20231116-include-only-jar-with-dependencies-ftl-generator branch from 95038c8 to 75ed8eb Compare November 27, 2023 18:27
@worstell worstell merged commit 2b18a9b into main Nov 27, 2023
15 of 16 checks passed
@worstell worstell deleted the worstell/20231116-include-only-jar-with-dependencies-ftl-generator branch November 27, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhanji dhanji Awaiting requested review from dhanji

@wesbillman wesbillman Awaiting requested review from wesbillman

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worstell @alecthomas