feat: allow empty data classes in kotlin schema #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
worstell
force-pushed
the
worstell/20231109-allow-empty-data-classes-kotlin
branch
from
6a502ce to
faef61e
Compare
Empty data classes can be defined in Kotlin as `typealias <ClassName> = Unit`
worstell
force-pushed
the
worstell/20231109-allow-empty-data-classes-kotlin
branch
from
faef61e to
c7974aa
Compare
alecthomas
reviewed
Nov 10, 2023
|
|
||
| // `typealias <name> = Unit` can be used in Kotlin to declare an empty FTL data type. | ||
| // This is a workaround to support empty objects in the FTL schema despite being unsupported by Kotlin data classes. | ||
| private fun KotlinType.isEmptyClassTypeAlias(): Boolean { |
alecthomas
approved these changes
Nov 10, 2023
worstell
deleted the
worstell/20231109-allow-empty-data-classes-kotlin
branch
alecthomas
added a commit
that referenced
this pull request
Nov 10, 2023
This reverts commit 5f74abb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty data classes can be defined in Kotlin as
typealias <ClassName> = Unit