feat: persist kotlin schemas during deploy #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
worstell
force-pushed
the
worstell/20231012-support-kotlin-schema
branch
2 times, most recently
from
bfed3b1 to
54ed725
Compare
worstell
force-pushed
the
worstell/20231019-hook-up-kotlin-schema
branch
from
0bfd460 to
8b8bd98
Compare
Base automatically changed from
worstell/20231012-support-kotlin-schema
to
main
October 19, 2023 19:54
alecthomas
approved these changes
Oct 19, 2023
cmd/ftl/cmd_deploy.go
Outdated
| } | ||
| // TODO(worstell): clean up deploy cmd to handle language-specific stuff | ||
| if config.Language == "kotlin" { | ||
| schemaDirectory := config.Schema |
There was a problem hiding this comment.
Is there some reason you thought a directory would be preferable? I thought this would just be a single file containing the module schema as a pb file.
There was a problem hiding this comment.
no i'm good with that!
cmd/ftl/cmd_deploy.go
Outdated
| Name: config.Module, | ||
| } | ||
| // TODO(worstell): clean up deploy cmd to handle language-specific stuff | ||
| if config.Language == "kotlin" { |
There was a problem hiding this comment.
This will be used for Go as well, so we can remove this condition.
There was a problem hiding this comment.
sg - i was thinking we'd eventually merge ftl-go behavior into ftl deploy and remove this during the refactor because i think presently this logic would break for Go modules (but maybe ftl deploy is already broken for go?)
will remove it!
There was a problem hiding this comment.
Yeah ftl delpoy doesn't currently work with Go
worstell
force-pushed
the
worstell/20231019-hook-up-kotlin-schema
branch
from
8b8bd98 to
93c6b4e
Compare
worstell
force-pushed
the
worstell/20231019-hook-up-kotlin-schema
branch
from
93c6b4e to
4ed5aca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.