fix: include JAR dependencies in Kotlin deploys #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding the following fragment to the POM:
```xml
<execution>
<id>copy-dependencies</id>
<phase>compile</phase>
<goals>
<goal>copy-dependencies</goal>
</goals>
<configuration>
<outputDirectory>${project.build.directory}/dependency</outputDirectory>
<includeScope>runtime</includeScope>
</configuration>
</execution>
```
`ftl deploy ./target` will upload all dependendcies as well as compiled
source. This actually works super well in practice, and I think we can
completely remove the need for building a custom `ftl-runner` Docker
image.
One issue is that this now results in the runners having to download
quite a few MB of artefacts on each deploy, but we can mitigate this by
making the controller->runner artefact download process incremental too,
and have each runner maintain its own cache. Probably something for
later though, as it's generally pretty fast so far.
alecthomas
force-pushed
the
aat/include-dependency-jars
branch
from
40457f8 to
9fe3eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding the following fragment to the POM:
ftl deploy ./targetwill upload all dependencies as well as compiled source. This actually works super well in practice, and I think we can completely remove the need for building a customftl-runnerDocker image.One issue is that this now results in the runners having to download quite a few MB of artefacts on each deploy, but we can mitigate this by making the controller->runner artefact download process incremental too, and have each runner maintain its own cache. Probably something for later though, as it's generally pretty fast so far (eg.
runner4 | info: Downloaded 148 artefacts in 1.562282s).