Improve ftl status output readability
#456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
|
Accidentally closed prior PR b/c renamed branch This is the active PR now |
|
Also formatted the |
alecthomas
requested changes
Oct 5, 2023
| @@ -27,7 +27,7 @@ func (s *psCmd) Run(ctx context.Context, client ftlv1connect.ControllerServiceCl | |||
| return errors.WithStack(err) | |||
| } | |||
| if s.JSON { | |||
| marshaller := jsonpb.Marshaler{} | |||
| marshaller := jsonpb.Marshaler{Indent: " "} | |||
There was a problem hiding this comment.
This one makes sense, but the other two shouldn't be indented, as they're part of a columnar output and indenting them will just corrupt the columns.
alecthomas
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added JSON formatting w/ indents & line breaks for the ftl status output -- previously was a giant JSON all on one line