feat(client): modules page with basic features set #439
Conversation
wiring up logic
…zoom-to-module-or-verb
stopping for the night
…zoom-to-module-or-verb
…zoom-to-module-or-verb
EdwardIrby
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
Screen.Recording.2023-10-04.at.1.42.59.PM.mov |
EdwardIrby
changed the title
| export const ModulesRequests: React.FC<{ | ||
| className?: string | ||
| modules: Module[] | ||
| }> = ({ className, modules }) => { |
There was a problem hiding this comment.
This is good for now, but makes me think we might want a timeline component that we can pass in events to in the future so we don't have to duplicate all this code.
| const VerbForm = ({ module, verb }: Props) => { | ||
| const client = useClient(VerbService) |
There was a problem hiding this comment.
There's a VerbForm component in the project today, would that work for this?
There was a problem hiding this comment.
It should work for now. I want to style the Editor to look better in the panel later. I'll switch for now
| interface MapValue { | ||
| deploymentName: string | ||
| id: string | ||
| verbs: Set<VerbId> | ||
| queriedVerbs: Set<VerbId> | ||
| } |
There was a problem hiding this comment.
MapValue seems a bit generic, is there a better name we could use here? Maybe like DeploymentVerbs or something? I'm cool if this makes sense as well.
There was a problem hiding this comment.
Honestly I started generic and never swapped in something better to describe it. Let's rename.
| const filters: EventsQuery_Filter[] = [] | ||
| if (deployments.length) { | ||
| filters.push(modulesFilter(deployments)) | ||
| } |
There was a problem hiding this comment.
This component is named ModuleRequests, so I just want to point out this is getting all events for a module. This would likely include Logs, Calls, Deployments etc. Is that what you're looking for here?
There was a problem hiding this comment.
For the moment yes. I need to site down and and figure out how to move to a more request trace based log like in the wireframes. Talk about it tomorrow?
note: there still some interactions and sizing on the svg I need to tighten up