Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up padding a bit with new layout #433

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: clean up padding a bit with new layout #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions console/client/src/features/modules/ModulePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const ModulePage = () => {
/>
<Page.Body className='p-4'>
<div className='flex-1 flex flex-col h-full'>
<div className='flex-1 m-4'>
<div className='flex-1'>
<div className='grid grid-cols-3 xl:grid-cols-4 2xl:grid-cols-5 gap-4'>
{module?.verbs.map((verb) => (
<Card
Expand All @@ -55,7 +55,7 @@ export const ModulePage = () => {
))}
</div>
</div>
<div className='flex-1 h-1/2 m-4'>
<div className='flex-1 h-1/2'>
<CallList calls={calls} />
</div>
</div>
Expand Down
5 changes: 4 additions & 1 deletion console/client/src/features/requests/RequestGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ interface CallBlockProps {
const CallBlock = ({ call, selectedCall, firstTimeStamp, firstDuration }: CallBlockProps) => {
const totalDurationMillis = (firstDuration.nanos ?? 0) / 1000000
const durationInMillis = (call.duration?.nanos ?? 0) / 1000000
const width = (durationInMillis / totalDurationMillis) * 100
let width = (durationInMillis / totalDurationMillis) * 100
if (width < 1) {
width = 1
}

const callTime = call.timeStamp?.toDate() ?? new Date()
const initialTime = firstTimeStamp?.toDate() ?? new Date()
Expand Down
4 changes: 2 additions & 2 deletions console/client/src/features/verbs/VerbPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export const VerbPage = () => {
/>
<Page.Body className='p-4'>
<div className='flex-1 flex flex-col h-full'>
<div className='flex-1 h-1/2 overflow-y-auto mx-4 mt-4'>
<div className='flex-1 h-1/2 overflow-y-auto'>
{verb?.verb?.request?.toJsonString() && (
<CodeBlock
code={buildVerbSchema(
Expand All @@ -62,7 +62,7 @@ export const VerbPage = () => {
/>
)}
</div>
<div className='flex-1 h-1/2 m-4'>
<div className='flex-1 h-1/2'>
<CallList calls={calls} />
</div>
</div>
Expand Down