Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update pubsub docs #3962

Merged
merged 3 commits into from
Jan 10, 2025
Merged

docs: update pubsub docs #3962

merged 3 commits into from
Jan 10, 2025

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Jan 10, 2025 •
edited
Loading

closes #3496

@matt2e matt2e requested a review from alecthomas as a code owner January 10, 2025 05:23
This was referenced Jan 10, 2025
Open
Open
@matt2e matt2e force-pushed the matt2e/pubsub/docs branch from 4a2fb7d to 7be7db1 Compare January 10, 2025 05:35
@matt2e matt2e requested review from wesbillman and removed request for alecthomas January 10, 2025 05:35
@wesbillman wesbillman requested a review from Copilot January 10, 2025 16:39
Copilot
Copilot AI reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

docs/content/docs/reference/pubsub.md Outdated Show resolved Hide resolved
docs/content/docs/reference/pubsub.md Outdated Show resolved Hide resolved
docs/content/docs/reference/pubsub.md Outdated
// ftl.TopicPartitionMap is an interface for mapping each event to a partition in the topic.
//
// If creating a topic with multiple partitions, you'll need to define a partition mapper for your event type.
// Otherwise you can use ftl.SingpePartitionMap[Event]
Copy link
Preview

Copilot AI Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type name 'ftl.SingpePartitionMap[Event]' is incorrect. It should be 'ftl.SinglePartitionMap[Event]'.

Suggested change
// Otherwise you can use ftl.SingpePartitionMap[Event]
// Otherwise you can use ftl.SinglePartitionMap[Event]

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@wesbillman wesbillman merged commit b5f43e7 into main Jan 10, 2025
62 checks passed
@wesbillman wesbillman deleted the matt2e/pubsub/docs branch January 10, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@wesbillman wesbillman wesbillman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs
2 participants
@matt2e @wesbillman