fix: case where a runner ends up reserved without a timeout #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this was being triggered when a controller creates a reservation transaction, issues the reservation to a runner, then dies before being able to complete the transaction. This leaves the runner in a state where it is telling controllers it's reserved, without having set a reservation_timeout, as the only place that was previously set was during the reservation transaction. The UpsertRunner calls were not setting this. To work around this, and another potential issue, I've added two triggers: 1. When a runner is set to the reserved state with a NULL reservation_timeout, set it to a default of 2m. 2. Update runner.module_name whenever runner.deployment_id is set or unset. Fixes #392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was being triggered when a controller creates a reservation transaction, issues the reservation to a runner, then dies before being able to complete the transaction. This leaves the runner in a state where it is telling controllers it's reserved, without having set a reservation_timeout, as the only place that was previously set was during the reservation transaction. The UpsertRunner calls were not setting this.
To work around this, and another potential issue, I've added two triggers:
Fixes #392