Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close consumer group #3815

Merged
merged 1 commit into from
Dec 18, 2024
Merged

fix: close consumer group #3815

merged 1 commit into from
Dec 18, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Dec 18, 2024

closes #3472

  • Rebalance after old deployment is killed is faster
  • Added integration test that checks to make sure slow consumers are not affected by rebalances (the call will fail due to rebalance and then try again after rebalance)

@matt2e matt2e requested a review from alecthomas as a code owner December 18, 2024 22:23
@alecthomas alecthomas mentioned this pull request Dec 18, 2024
Open
@matt2e matt2e enabled auto-merge (squash) December 18, 2024 22:31
@matt2e matt2e merged commit c24e6fe into main Dec 18, 2024
94 of 96 checks passed
@matt2e matt2e deleted the matt2e/pubsub/rebalance branch December 18, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration tests for rebalancing consumer groups
1 participant
@matt2e