Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subscription annotation values #3761

Closed
wants to merge 1 commit into from

Conversation

stuartwdouglas
Copy link
Collaborator

No description provided.

@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/sub-fixes branch from 6388caa to d92cd04 Compare December 16, 2024 01:37
@alecthomas alecthomas self-requested a review as a code owner December 16, 2024 01:40
@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/sub-fixes branch 2 times, most recently from 75ed835 to dfecaaa Compare December 16, 2024 01:50
Copy link
Collaborator

@matt2e matt2e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matt2e
Copy link
Collaborator

matt2e commented Dec 16, 2024

Not sure why theres all the proto changes though

@matt2e matt2e force-pushed the stuartwdouglas/sub-fixes branch from 3c4cd3d to 0073b8a Compare December 16, 2024 02:20
This was referenced Dec 16, 2024
@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/sub-fixes branch from 0073b8a to bde16e2 Compare December 16, 2024 02:51
@stuartwdouglas
Copy link
Collaborator Author

Not sure why theres all the proto changes though

Issues with the rename unrelated to this PR

@matt2e matt2e force-pushed the stuartwdouglas/sub-fixes branch from bde16e2 to 9b60315 Compare December 16, 2024 03:30
@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/sub-fixes branch from 9b60315 to 880fbd2 Compare December 16, 2024 03:40
@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/sub-fixes branch from 039efcb to e2b406a Compare December 16, 2024 05:11
@matt2e
Copy link
Collaborator

matt2e commented Dec 16, 2024

Closing this, ended up bring the changes into my own branch

@matt2e matt2e closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants