fix: inject timeline client instead of using ctx #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
reviewed
Dec 11, 2024
| @@ -40,18 +40,6 @@ func NewClient(ctx context.Context, endpoint *url.URL) *Client { | |||
| return client | |||
| } | |||
|
|
|||
| func ContextWithClient(ctx context.Context, client *Client) context.Context { | |||
There was a problem hiding this comment.
can delete line 23 as well (type timelineContextKey struct{})
There was a problem hiding this comment.
Ahh yeah, will do! Thanks :)
worstell
approved these changes
Dec 11, 2024
wesbillman
force-pushed
the
fix-timeline-from-context
branch
from
a373bbf to
af54cb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3708
Fixes #3704