feat: publish to timeline and telemetry when calling via p2p routing #3687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
matt2e
force-pushed
the
matt2e/p2p-routing-to-timeline
branch
2 times, most recently
from
6582b46 to
5c3195e
Compare
matt2e
force-pushed
the
matt2e/p2p-routing-to-timeline
branch
from
5c3195e to
2376574
Compare
# Conflicts: # backend/protos/xyz/block/ftl/deployment/v1/deployment.pb.go # backend/runner/proxy/proxy.go # python-runtime/ftl/src/ftl/protos/xyz/block/ftl/deployment/v1/deployment_pb2.py
matt2e
force-pushed
the
matt2e/p2p-routing-to-timeline
branch
from
2376574 to
cb0661e
Compare
stuartwdouglas
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VerbCallRouterfor everything elseRunners now need to know the deployment they are routing to to record events properly.
Previously, routing in the deployment context only mapped module to endpoint. I've changed this to pass along deployment instead.
Also fixes as issue where runners would keep old verb clients around pointing to the original endpoint for a module even if it had since changed.
closes #3669