feat: timeline events for async calls #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
approved these changes
Oct 31, 2024
| func (e *AsyncExecuteEvent) GetID() int64 { return e.ID } | ||
| func (e *AsyncExecuteEvent) event() {} | ||
|
|
||
| type AsyncExecute struct { |
There was a problem hiding this comment.
We'll want the async type here somewhere no?
deniseli
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Nice! Re: icons - I used https://hugeicons.com/icon/clock-01-stroke-standard for cron jobs verbs if you want to reuse it, though the one you have looks good too, and I do sort of wonder if it's better to use a similar icon instead of the same one when it's an event instead of the verb itself? Up to you! This looks awesome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds timeline events for async dequeues and errors.
Closes #3282