Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cron jobs on deactivation #3122

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

stuartwdouglas
Copy link
Collaborator

fixes #3109

@stuartwdouglas stuartwdouglas requested review from a team and jonathanj-square and removed request for a team October 15, 2024 01:37
This was referenced Oct 15, 2024
@stuartwdouglas
Copy link
Collaborator Author

Turns out this needs more thought, it leads to import cycles in other tests.

@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/cron-fixes branch from 48ed49c to b2a5d89 Compare October 15, 2024 02:10
Copy link
Contributor

@jvmakine jvmakine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stuartwdouglas stuartwdouglas merged commit 5ed558d into main Oct 15, 2024
96 checks passed
@stuartwdouglas stuartwdouglas deleted the stuartwdouglas/cron-fixes branch October 15, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cron methods called multiple times for long running deployments
2 participants