feat: Improve local subscriptions #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team,
tomdaffurn and
safeer
and removed request for
a team
|
@alecthomas I think this should address your type safety concerns from last week. Unfortunately it does not help with same module verb invocation though, I am still not sure how to be make that type safe. |
tomdaffurn
approved these changes
Oct 9, 2024
stuartwdouglas
force-pushed
the
stuartwdouglas/local-jvm-subscriptions
branch
from
1d79ea7 to
dce464a
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/local-jvm-subscriptions
branch
from
dce464a to
ae97fe3
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/local-jvm-subscriptions
branch
from
ae97fe3 to
80348ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.