chore: pubsub docs for JVM #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team and
matt2e
and removed request for
a team
wesbillman
approved these changes
Oct 4, 2024
alecthomas
approved these changes
Oct 4, 2024
| ``` | ||
|
|
||
| This is ok, but it requires the use of string constants for the topic name, which can be error-prone. If you are subscribing to a topic from | ||
| another module, FTL will generate a type-safe subscription meta annotation you can use to subscribe to the topic: |
There was a problem hiding this comment.
I really don't love this as an end state, is there a way we can have type safety for topics in the same module too?
There was a problem hiding this comment.
I think you could just directly reference the topic in this case, I will put up a PR next week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2887