feat: dev provisioner for postgres #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvmakine
requested review from
a team and
wesbillman
and removed request for
a team
github-actions
bot
changed the title
Open
alecthomas
approved these changes
Oct 3, 2024
| resp, err := t.handler.Provision(ctx, connect.NewRequest(&provisioner.ProvisionRequest{ | ||
| Module: t.module, | ||
| // TODO: We need a proper cluster specific ID here | ||
| FtlClusterId: "ftl", |
There was a problem hiding this comment.
This is available in the ProjectConfig as "Realm"
There was a problem hiding this comment.
👍 I might wire that in in a separate PR. That seems to be a bit of work to get in place properly.
| done atomic.Bool | ||
| } | ||
|
|
||
| // Provisioner is a provisioner for running FTL locally |
| step := &step{resource: r.Resource} | ||
| task.steps = append(task.steps, step) | ||
|
|
||
| d.provisionPostgres(ctx, tr, req.Msg.Module, r.Resource.ResourceId, step) |
There was a problem hiding this comment.
Does this not return errors?
There was a problem hiding this comment.
No, it stores the result to step which could include an error if the step failed.
|
Awesome, I'm really looking forward to this going in, it will make life so much nicer for users. |
jvmakine
force-pushed
the
juho/dev-provisioner
branch
from
540cd70 to
2c37798
Compare
jvmakine
force-pushed
the
juho/dev-provisioner
branch
9 times, most recently
from
0645135 to
842a530
Compare
jvmakine
force-pushed
the
juho/dev-provisioner
branch
from
c8ff500 to
35a524c
Compare
jvmakine
force-pushed
the
juho/dev-provisioner
branch
from
a4e37df to
ebf83e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains a bit of refactoring to remove unnecessary
Provisionerinterface, and use the plugin API directly for embedded provisioners.We also extract
SetupDBfromftl serveto start the docker image for postgres in thedevprovisioner if it is not running.Next, we should automatically inject the secrets to make the created DB actually usable.