feat: capture Kotlin comments #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team,
tomdaffurn and
deniseli
and removed request for
a team
stuartwdouglas
force-pushed
the
stuartwdouglas/2418
branch
from
ff9935a to
a2635f1
Compare
tomdaffurn
approved these changes
Oct 2, 2024
| <annotationProcessorPath> | ||
| <groupId>xyz.block.ftl</groupId> | ||
| <artifactId>ftl-java-runtime</artifactId> | ||
| <version>${project.version}</version> |
There was a problem hiding this comment.
Is this running AnnotationProcessor in the Kotlin build?
There was a problem hiding this comment.
Yes, it turns out that this is supported. Kotlin 2.0 is bringing in a new approach but it seems a bit immature at the moment.
Thinking about it I guess I should move the processor to common.
stuartwdouglas
force-pushed
the
stuartwdouglas/2418
branch
4 times, most recently
from
e20913b to
da0d80d
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/2418
branch
from
da0d80d to
711ea4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2418