Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verb call order #2940

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

worstell
Copy link
Contributor

@worstell worstell commented Oct 1, 2024

we can't sort this way because the generated resource providers need to match the param ordering to ensure they pass the correct resources in place. will have to think of another solution to stable sort here

@worstell worstell requested a review from a team as a code owner October 1, 2024 23:46
@worstell worstell requested review from alecthomas and removed request for a team October 1, 2024 23:46
@worstell worstell force-pushed the worstell/20241001-fix-verb-call-order branch from 3798737 to 0235a53 Compare October 1, 2024 23:46
This was referenced Oct 1, 2024
we can't sort this way because the generated resource providers need to match the param ordering to ensure they pass
the correct resources in place. will have to think of another solution to stable sort here
@worstell worstell force-pushed the worstell/20241001-fix-verb-call-order branch from 0235a53 to 9276418 Compare October 1, 2024 23:49
@worstell worstell enabled auto-merge (squash) October 1, 2024 23:50
@worstell worstell merged commit 23842d7 into main Oct 1, 2024
93 checks passed
@worstell worstell deleted the worstell/20241001-fix-verb-call-order branch October 1, 2024 23:56
@alecthomas
Copy link
Collaborator

Mind creating an issue to track this?

@worstell
Copy link
Contributor Author

worstell commented Oct 2, 2024

Mind creating an issue to track this?

done! #2941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants