Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing types in genned files #2933

Merged
merged 1 commit into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 53 additions & 35 deletions go-runtime/compile/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,13 +59,12 @@ type mainModuleContext struct {
TypesCtx typesFileContext
}

func (c mainModuleContext) withImports(mainModuleImport string) mainModuleContext {
func (c *mainModuleContext) withImports(mainModuleImport string) {
c.MainCtx.Imports = c.generateMainImports()
c.TypesCtx.Imports = c.generateTypesImports(mainModuleImport)
return c
}

func (c mainModuleContext) generateMainImports() []string {
func (c *mainModuleContext) generateMainImports() []string {
imports := sets.NewSet[string]()
imports.Add(`"context"`)
imports.Add(`"github.com/TBD54566975/ftl/backend/protos/xyz/block/ftl/v1/ftlv1connect"`)
Expand All @@ -90,7 +89,7 @@ func (c mainModuleContext) generateMainImports() []string {
return imports.ToSlice()
}

func (c mainModuleContext) generateTypesImports(mainModuleImport string) []string {
func (c *mainModuleContext) generateTypesImports(mainModuleImport string) []string {
imports := sets.NewSet[string]()
if len(c.TypesCtx.SumTypes) > 0 || len(c.TypesCtx.ExternalTypes) > 0 {
imports.Add(`"github.com/TBD54566975/ftl/go-runtime/ftl/reflection"`)
Expand Down Expand Up @@ -563,7 +562,7 @@ func buildMainModuleContext(sch *schema.Schema, result extract.Result, goModVers

func (b *mainModuleContextBuilder) build(goModVersion, ftlVersion, projectName string,
sharedModulesPaths []string, replacements []*modfile.Replace) (mainModuleContext, error) {
ctx := mainModuleContext{
ctx := &mainModuleContext{
GoVersion: goModVersion,
FTLVersion: ftlVersion,
Name: b.mainModule.Name,
Expand All @@ -582,8 +581,53 @@ func (b *mainModuleContextBuilder) build(goModVersion, ftlVersion, projectName s
}

visited := sets.NewSet[string]()
err := schema.Visit(b.mainModule, func(node schema.Node, next func() error) error {
maybeGoType, isLocal, err := b.getGoType(b.mainModule, node)
err := b.visit(ctx, b.mainModule, b.mainModule, visited)
if err != nil {
return mainModuleContext{}, err
}

slices.SortFunc(ctx.MainCtx.SumTypes, func(a, b goSumType) int {
return strings.Compare(a.TypeName(), b.TypeName())
})
slices.SortFunc(ctx.TypesCtx.SumTypes, func(a, b goSumType) int {
return strings.Compare(a.TypeName(), b.TypeName())
})

ctx.TypesCtx.MainModulePkg = b.mainModule.Name
mainModuleImport := fmt.Sprintf("ftl/%s", b.mainModule.Name)
if alias, ok := b.imports[mainModuleImport]; ok {
mainModuleImport = fmt.Sprintf("%s %q", alias, mainModuleImport)
ctx.TypesCtx.MainModulePkg = alias
}
ctx.withImports(mainModuleImport)
return *ctx, nil
}

func (b *mainModuleContextBuilder) visit(
ctx *mainModuleContext,
module *schema.Module,
node schema.Node,
visited sets.Set[string],
) error {
err := schema.Visit(node, func(node schema.Node, next func() error) error {
if ref, ok := node.(*schema.Ref); ok {
maybeResolved, maybeModule := b.sch.ResolveWithModule(ref)
resolved, ok := maybeResolved.Get()
if !ok {
return next()
}
m, ok := maybeModule.Get()
if !ok {
return next()
}
err := b.visit(ctx, m, resolved, visited)
if err != nil {
return fmt.Errorf("failed to visit children of %s: %w", ref, err)
}
return next()
}

maybeGoType, isLocal, err := b.getGoType(module, node)
if err != nil {
return err
}
Expand Down Expand Up @@ -611,40 +655,14 @@ func (b *mainModuleContextBuilder) build(goModVersion, ftlVersion, projectName s
return next()
})
if err != nil {
return mainModuleContext{}, fmt.Errorf("failed to build main module context: %w", err)
}

slices.SortFunc(ctx.MainCtx.SumTypes, func(a, b goSumType) int {
return strings.Compare(a.TypeName(), b.TypeName())
})
slices.SortFunc(ctx.TypesCtx.SumTypes, func(a, b goSumType) int {
return strings.Compare(a.TypeName(), b.TypeName())
})

ctx.TypesCtx.MainModulePkg = b.mainModule.Name
mainModuleImport := fmt.Sprintf("ftl/%s", b.mainModule.Name)
if alias, ok := b.imports[mainModuleImport]; ok {
mainModuleImport = fmt.Sprintf("%s %q", alias, mainModuleImport)
ctx.TypesCtx.MainModulePkg = alias
return fmt.Errorf("failed to build main module context: %w", err)
}
return ctx.withImports(mainModuleImport), nil
return nil
}

func (b *mainModuleContextBuilder) getGoType(module *schema.Module, node schema.Node) (gotype optional.Option[goType], isLocal bool, err error) {
isLocal = b.visitingMainModule(module.Name)
switch n := node.(type) {
case *schema.Ref:
maybeResolved, maybeModule := b.sch.ResolveWithModule(n)
resolved, ok := maybeResolved.Get()
if !ok {
return optional.None[goType](), isLocal, nil
}
m, ok := maybeModule.Get()
if !ok {
return optional.None[goType](), isLocal, nil
}
return b.getGoType(m, resolved)

case *schema.Verb:
if !isLocal {
return optional.None[goType](), false, nil
Expand Down
2 changes: 2 additions & 0 deletions internal/buildengine/testdata/alpha/types.ftl.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions internal/buildengine/testdata/type_registry_main.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading