Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove ftl.Call #2932

Merged
merged 2 commits into from
Oct 1, 2024
Merged

refactor: remove ftl.Call #2932

merged 2 commits into from
Oct 1, 2024

Conversation

worstell
Copy link
Contributor

@worstell worstell commented Oct 1, 2024

  • removes call.go from go-runtime library
  • removes old generated verb stubs
  • updates all usages of ftl.Call to the new pattern
  • adds build error when direct verb invocations are detected

@worstell worstell requested review from a team and alecthomas as code owners October 1, 2024 20:15
@worstell worstell requested review from a team and deniseli and removed request for a team October 1, 2024 20:15
This was referenced Oct 1, 2024
Open
Open
deniseli
deniseli approved these changes Oct 1, 2024
View reviewed changes
go-runtime/schema/common/fact.go Show resolved Hide resolved
@worstell worstell force-pushed the worstell/20240930-delete-ftl-call branch 4 times, most recently from ce73b9a to 4ed4c02 Compare October 1, 2024 22:15
@worstell worstell force-pushed the worstell/20240930-delete-ftl-call branch from 4ed4c02 to ced8161 Compare October 1, 2024 22:15
@worstell worstell merged commit 53d08d1 into main Oct 1, 2024
93 checks passed
@worstell worstell deleted the worstell/20240930-delete-ftl-call branch October 1, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniseli deniseli deniseli approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@worstell @deniseli