Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't cache SNAPSHOT versions #2912

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

stuartwdouglas
Copy link
Collaborator

I am not 100% sure this will work, but the docs seem to imply it will.

@stuartwdouglas stuartwdouglas requested review from a team and safeer and removed request for a team September 30, 2024 22:58
This was referenced Sep 30, 2024
Copy link
Contributor

@jvmakine jvmakine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what is happening here, but how bad can a 3 line change be!

@stuartwdouglas
Copy link
Collaborator Author

So when you build FTL JVM mvn install will install those artifacts in the .m2/repository, which means they get written back into the cache. If you don't explicitly build Java in your test you can end up using the Java artifacts from another PR.

@stuartwdouglas
Copy link
Collaborator Author

This also means that if you forget to build Java your tests might still pass using the Java artifacts from another PR, but then when the SNAPSHOT artifacts expire the next day things will start failing, which is what happened with TestSmokeTest

I am not 100% sure this will work, but the docs seem to imply it will.
@stuartwdouglas stuartwdouglas force-pushed the stuartwdouglas/dont-cache-snapshot branch from 334f9b8 to 19f1907 Compare September 30, 2024 23:53
@stuartwdouglas stuartwdouglas merged commit 4afe64e into main Oct 1, 2024
93 checks passed
@stuartwdouglas stuartwdouglas deleted the stuartwdouglas/dont-cache-snapshot branch October 1, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants