fix: ftl dev failing from go.mod files #2911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
requested review from
a team and
deniseli
and removed request for
a team
Open
wesbillman
commented
Sep 30, 2024
| @@ -4,7 +4,7 @@ go 1.23.0 | |||
|
|
|||
| replace github.com/TBD54566975/ftl => ../../.. | |||
|
|
|||
| require github.com/TBD54566975/ftl v0.248.0 | |||
| require github.com/TBD54566975/ftl v0.0.0-00010101000000-000000000000 | |||
There was a problem hiding this comment.
@alecthomas I wasn't 100% sure on this, but noticed that echo and time had different versions here so I made all of them the same. 😬
There was a problem hiding this comment.
If a correct replace directive exists, the version is irrelevant, so it doesn't hurt.
Open
wesbillman
commented
Sep 30, 2024
Comment on lines
-48
to
+49
| replace github.com/TBD54566975/ftl => /Users/safeer/dev/ftl | ||
| replace github.com/TBD54566975/ftl => ../.. |
There was a problem hiding this comment.
This was the main change/fix for this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.