Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove module from status line #2907

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: remove module from status line #2907

merged 1 commit into from
Sep 30, 2024

Conversation

stuartwdouglas
Copy link
Collaborator

@stuartwdouglas stuartwdouglas commented Sep 30, 2024 •
edited
Loading

fixes #2900

@stuartwdouglas stuartwdouglas requested review from a team and gak and removed request for a team September 30, 2024 21:17
This was referenced Sep 30, 2024
Open
Open
@stuartwdouglas stuartwdouglas merged commit 6275fac into main Sep 30, 2024
96 checks passed
@stuartwdouglas stuartwdouglas deleted the stuartwdouglas/2900 branch September 30, 2024 22:34
matt2e
matt2e reviewed Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@matt2e matt2e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartwdouglas are we missing the code passing the new state in?

@stuartwdouglas stuartwdouglas restored the stuartwdouglas/2900 branch September 30, 2024 23:51
@stuartwdouglas
Copy link
Collaborator Author

Ugh, I had this locally, looks like the second git push didn't actually work because of a transient failure in the pre-push hook, and I didn't notice. Proper fix is: #2916

@stuartwdouglas stuartwdouglas deleted the stuartwdouglas/2900 branch September 30, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt2e matt2e matt2e left review comments

@wesbillman wesbillman wesbillman approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@gak gak Awaiting requested review from gak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removed modules do not get removed from CLI status section
3 participants
@stuartwdouglas @wesbillman @matt2e