feat: send ingress requests via http #2825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesbillman
requested review from
a team and
stuartwdouglas
and removed request for
a team
Open
wesbillman
commented
Sep 25, 2024
| @@ -9,6 +10,7 @@ export const AppProvider = () => { | |||
| <UserPreferencesProvider> | |||
| <NotificationsProvider> | |||
| <RoutingProvider /> | |||
| <Notification /> | |||
There was a problem hiding this comment.
This fixes notifications :)
Open
AlexSzlavik
approved these changes
Sep 25, 2024
wesbillman
requested review from
deniseli
and removed request for
stuartwdouglas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2720
Fixes #2753 (will add similar functionality to request/events page in the future)
With this change we can now see
ingressevents are part of the request since we're using fetch.Copy
curlCopy
ftl.call