fix: GetActiveDeployments fix #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team and
worstell
and removed request for
a team
tomdaffurn
approved these changes
Sep 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
stuartwdouglas
added
the
run-all
stuartwdouglas
force-pushed
the
stuartwdouglas/active-fix
branch
2 times, most recently
from
a8a8b33 to
9f95a9d
Compare
| @@ -123,8 +123,8 @@ ORDER BY r.key; | |||
| SELECT sqlc.embed(d), m.name AS module_name, m.language, COUNT(r.id) AS replicas | |||
| FROM deployments d | |||
| JOIN modules m ON d.module_id = m.id | |||
| LEFT JOIN runners r ON d.id = r.deployment_id | |||
| WHERE min_replicas > 0 AND r.state = 'assigned' | |||
| LEFT JOIN runners r ON d.id = r.deployment_id AND r.state = 'assigned' | |||
There was a problem hiding this comment.
nice pre-join filtering performance improvement!
There was a problem hiding this comment.
It changes the query behaviour. If you have an 'idle' runner with the current query it will join the deployment, then get filtered out in the where clause. Filtering it here means that it just won't join, so the runner count will be zero but you still see the deployment row.
stuartwdouglas
force-pushed
the
stuartwdouglas/active-fix
branch
from
9f95a9d to
6d62bdf
Compare
stuartwdouglas
force-pushed
the
stuartwdouglas/active-fix
branch
from
6d62bdf to
181505f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.