fix: consider the schema active even with no runners #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team and
jonathanj-square
and removed request for
a team
alecthomas
approved these changes
Sep 11, 2024
|
I think you might need to separate the queries |
That won't help unfortunately. I think the issue is now that the build command sees the schema ready early, so the call it attempted before the runner is up, not that this query affects the routing table. |
stuartwdouglas
force-pushed
the
kube-active-deployments
branch
from
2face11 to
d857b16
Compare
|
Turns out a slight change to the query was needed. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tomdaffurn
approved these changes
Sep 11, 2024
| @@ -392,7 +392,7 @@ func (s *Service) registrationLoop(ctx context.Context, send func(request *ftlv1 | |||
| s.state.Store(state) | |||
| } | |||
|
|
|||
| logger.Infof("Registering with Controller as %s for deployment %s", state, s.config.Deployment) | |||
| logger.Debugf("Registering with Controller as %s for deployment %s", state, s.config.Deployment) | |||
There was a problem hiding this comment.
yessss. This is hitting PFI right now
stuartwdouglas
force-pushed
the
kube-active-deployments
branch
from
d857b16 to
dce159a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.