Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(biome): use hermit biome instead of pnpm #2615

Merged
merged 1 commit into from
Sep 4, 2024
Merged

chore(biome): use hermit biome instead of pnpm #2615

merged 1 commit into from
Sep 4, 2024

Conversation

wesbillman
Copy link
Collaborator

@wesbillman wesbillman commented Sep 4, 2024 •
edited by alecthomas
Loading

The reason for this is that for some inexplicable reason the NPM package downloads binaries for all architectures, each of which are ~9MB:

Downloading @biomejs/[email protected]: 8.43 MB/8.43 MB, done
Downloading @biomejs/[email protected]: 8.62 MB/8.62 MB, done
Downloading @biomejs/[email protected]: 9.08 MB/9.08 MB, done
Downloading @biomejs/[email protected]: 9.09 MB/9.09 MB, done
Downloading @biomejs/[email protected]: 9.79 MB/9.79 MB, done
Downloading @biomejs/[email protected]: 9.09 MB/9.09 MB, done
Downloading @biomejs/[email protected]: 9.40 MB/9.40 MB, done
Downloading @biomejs/[email protected]: 9.68 MB/9.68 MB, done

@wesbillman wesbillman requested review from a team, gak and deniseli and removed request for a team September 4, 2024 20:23
@alecthomas alecthomas added this pull request to the merge queue Sep 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 4, 2024
@wesbillman wesbillman added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit c633e59 Sep 4, 2024
26 checks passed
@wesbillman wesbillman deleted the hermitize-biome branch September 4, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniseli deniseli deniseli approved these changes

@gak gak gak approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wesbillman @gak @deniseli