Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for build env vars #2609

Merged
merged 1 commit into from
Sep 4, 2024
Merged

feat: allow for build env vars #2609

merged 1 commit into from
Sep 4, 2024

Conversation

stuartwdouglas
Copy link
Collaborator

This allows for multi platform builds on go

@stuartwdouglas stuartwdouglas requested review from a team and worstell and removed request for a team September 4, 2024 01:51
This was referenced Sep 3, 2024
internal/buildengine/engine.go Outdated Show resolved Hide resolved
This allows for multi platform builds on go
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stuartwdouglas stuartwdouglas added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit efc799d Sep 4, 2024
23 checks passed
@stuartwdouglas stuartwdouglas deleted the build-env-vars branch September 4, 2024 03:16
@worstell worstell added the approved Marks an already closed PR as approved label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Marks an already closed PR as approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants